mcvsubbu commented on a change in pull request #6655:
URL: https://github.com/apache/incubator-pinot/pull/6655#discussion_r590566582
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
##########
@@ -222,10 +222,10 @@ public void setUpNewTable(TableConfig tableConfig,
IdealState idealState) {
long currentTimeMs = getCurrentTimeMs();
Map<String, Map<String, String>> instanceStatesMap =
idealState.getRecord().getMapFields();
- for (int partitionId = 0; partitionId < numPartitions; partitionId++) {
Review comment:
+1
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
##########
@@ -211,13 +211,13 @@ public void deleteSegmentFile() {
private final String _resourceDataDir;
private final IndexLoadingConfig _indexLoadingConfig;
private final Schema _schema;
- // Semaphore for each partitionId only, which is to prevent two different
Kafka consumers
- // from consuming with the same partitionId in parallel in the same host.
+ // Semaphore for each partitionGroupId only, which is to prevent two
different Kafka consumers
Review comment:
```suggestion
// Semaphore for each partitionGroupId only, which is to prevent two
different Stream consumers
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
