This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 5137025 Remove methods in PinotMetricsRegistryListener (#6630)
5137025 is described below
commit 513702582e620829419a93c322740a7193e941c3
Author: Jialiang Li <j...@linkedin.com>
AuthorDate: Fri Mar 5 15:45:53 2021 -0800
Remove methods in PinotMetricsRegistryListener (#6630)
Co-authored-by: Jack Li(Analytics Engineering) <j...@jlli-mn1.linkedin.biz>
---
.../metrics/yammer/YammerMetricsRegistryListener.java | 14 --------------
.../pinot/spi/metrics/PinotMetricsRegistryListener.java | 14 --------------
2 files changed, 28 deletions(-)
diff --git
a/pinot-common/src/main/java/org/apache/pinot/common/metrics/yammer/YammerMetricsRegistryListener.java
b/pinot-common/src/main/java/org/apache/pinot/common/metrics/yammer/YammerMetricsRegistryListener.java
index b449057..20646ae 100644
---
a/pinot-common/src/main/java/org/apache/pinot/common/metrics/yammer/YammerMetricsRegistryListener.java
+++
b/pinot-common/src/main/java/org/apache/pinot/common/metrics/yammer/YammerMetricsRegistryListener.java
@@ -18,11 +18,7 @@
*/
package org.apache.pinot.common.metrics.yammer;
-import com.yammer.metrics.core.Metric;
-import com.yammer.metrics.core.MetricName;
import com.yammer.metrics.core.MetricsRegistryListener;
-import org.apache.pinot.spi.metrics.PinotMetric;
-import org.apache.pinot.spi.metrics.PinotMetricName;
import org.apache.pinot.spi.metrics.PinotMetricsRegistryListener;
@@ -34,16 +30,6 @@ public class YammerMetricsRegistryListener implements
PinotMetricsRegistryListen
}
@Override
- public void onMetricAdded(PinotMetricName name, PinotMetric metric) {
- _metricsRegistryListener.onMetricAdded((MetricName) name.getMetricName(),
(Metric) metric.getMetric());
- }
-
- @Override
- public void onMetricRemoved(PinotMetricName name) {
- _metricsRegistryListener.onMetricRemoved((MetricName)
name.getMetricName());
- }
-
- @Override
public Object getMetricsRegistryListener() {
return _metricsRegistryListener;
}
diff --git
a/pinot-spi/src/main/java/org/apache/pinot/spi/metrics/PinotMetricsRegistryListener.java
b/pinot-spi/src/main/java/org/apache/pinot/spi/metrics/PinotMetricsRegistryListener.java
index d3237ce..f0ec9d9 100644
---
a/pinot-spi/src/main/java/org/apache/pinot/spi/metrics/PinotMetricsRegistryListener.java
+++
b/pinot-spi/src/main/java/org/apache/pinot/spi/metrics/PinotMetricsRegistryListener.java
@@ -22,20 +22,6 @@ package org.apache.pinot.spi.metrics;
* Listeners for events from the registry. Listeners must be thread-safe.
*/
public interface PinotMetricsRegistryListener {
- /**
- * Called when a metric has been added to the {@link PinotMetricsRegistry}.
- *
- * @param name the name of the {@link PinotMetric}
- * @param metric the {@link PinotMetric}
- */
- void onMetricAdded(PinotMetricName name, PinotMetric metric);
-
- /**
- * Called when a metric has been removed from the {@link
PinotMetricsRegistry}.
- *
- * @param name the name of the {@link PinotMetric}
- */
- void onMetricRemoved(PinotMetricName name);
/**
* Returned the actual object of MetricsRegistryListener.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
