[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6635: In PinotDataType, trim the string before converting to other types

[GitBox]

mayankshriv commented on a change in pull request #6635:
URL: https://github.com/apache/incubator-pinot/pull/6635#discussion_r586780039



##########
File path: 
pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java
##########
@@ -317,22 +317,24 @@ public Double convert(Object value, PinotDataType 
sourceType) {
   STRING {
     @Override
     public Integer toInteger(Object value) {
-      return Integer.parseInt((String) value);
+      return Integer.valueOf(((String) value).trim());

Review comment:
       This adds overhead on the happy path (which would be the most common 
case)? Is it worth enough to only trim in case of exception?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org