jackjlli commented on a change in pull request #6583:
URL: https://github.com/apache/incubator-pinot/pull/6583#discussion_r583158060
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/CompatibilityOpsRunner.java
##########
@@ -36,8 +35,7 @@ private CompatibilityOpsRunner(String configFileName) {
_configFileName = configFileName;
}
- private boolean runOps()
- throws IOException, JsonParseException, JsonMappingException {
+ private boolean runOps() throws IOException, JsonParseException,
JsonMappingException, InterruptedException {
Review comment:
I'd suggest throwing a generic `Exception` instead of putting all the
concrete ones here.
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/QueryOp.java
##########
@@ -55,7 +72,97 @@ public void setExpectedResultsFileName(String
expectedResultsFileName) {
@Override
boolean runOp() {
- System.out.println("Verifying queries in " + _queryFileName + " against
results in " + _expectedResultsFileName);
- return true;
+ System.out.printf("Verifying queries in %s against results in %s\n",
_queryFileName, _expectedResultsFileName);
Review comment:
Then why use `printf` instead of `println` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
