jihaozh commented on pull request #6601: URL: https://github.com/apache/incubator-pinot/pull/6601#issuecomment-783799260
> @jihaozh , IIUC, this is related to the invalid query compilation issues at Li. There were 2 things that need to be done to fix the queries > > * Escape reserved keywords with double quotes > * Use string filter literals in single quotes. > > I don't think this PR takes care of both. Also, to make sure everything has been covered, I hope the internal wiki for correct SQL syntax I pointed to was followed? As discussed offline, another PR should already take care of it. Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
