sajjad-moradi commented on a change in pull request #6546:
URL: https://github.com/apache/incubator-pinot/pull/6546#discussion_r578068608
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/data/generator/StringGenerator.java
##########
@@ -56,11 +65,18 @@ public void init() {
@Override
public Object next() {
+ if (numberOfValuesPerEntry == 1) {
+ return getNextString();
+ }
+ return
MultiValueGeneratorHelper.generateMultiValueEntries(numberOfValuesPerEntry,
rand, this::getNextString);
+ }
+
+ private String getNextString() {
return vals.get(rand.nextInt(cardinality));
Review comment:
That's correct, but even with completed segments, `MemoryEstimator`
tries to extrapolate the actual memory size based on secondsToConsume (derived
from numHours input) parameter:
```java
int totalDocs = (int) (((double) secondsToConsume /
_sampleSegmentConsumedSeconds) * _totalDocsInSampleSegment);
long memoryForConsumingSegmentPerPartition =
getMemoryForConsumingSegmentPerPartition(statsFile, totalDocs);
```
My point is that we have only one completed segment (given or generated) and
that should be enough to for estimating memory for different consumption window
sizes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
