Jackie-Jiang commented on a change in pull request #6577:
URL: https://github.com/apache/incubator-pinot/pull/6577#discussion_r575712062
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/store/SingleFileIndexDirectory.java
##########
@@ -258,15 +255,15 @@ private void mapBufferEntries()
IndexEntry entry = offsetEntry.getValue();
runningSize += entry.size;
- if (runningSize >= MAX_ALLOCATION_SIZE) {
+ if (runningSize >= MAX_ALLOCATION_SIZE && !offsetAccum.isEmpty()) {
Review comment:
No, that won't happen. It will work the same as before but preventing
the exception. When the second index come, we will load the first index, and
the second index will get into the next file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
