Jackie-Jiang commented on a change in pull request #6515:
URL: https://github.com/apache/incubator-pinot/pull/6515#discussion_r568220638
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/HelixBrokerStarter.java
##########
@@ -133,9 +133,7 @@ public HelixBrokerStarter(PinotConfiguration brokerConf,
String clusterName, Str
private int inferPort() {
return
Optional.ofNullable(_brokerConf.getProperty(Helix.KEY_OF_BROKER_QUERY_PORT)).map(Integer::parseInt)
Review comment:
We don't need to check the `Helix.KEY_OF_BROKER_QUERY_PORT` because it
will always be the first in the listenerConfigs if exists?
```suggestion
return _listenerConfigs.get(0).getPort();
```
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerStarter.java
##########
@@ -195,9 +195,7 @@ private void inferHostnameIfNeeded(ControllerConf config) {
private int inferPort() {
return
Optional.ofNullable(_config.getControllerPort()).map(Integer::parseInt)
Review comment:
```suggestion
return _listenerConfigs.get(0).getPort();
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
