apucher commented on a change in pull request #6515:
URL: https://github.com/apache/incubator-pinot/pull/6515#discussion_r568180523



##########
File path: 
pinot-core/src/main/java/org/apache/pinot/core/util/ListenerConfigUtil.java
##########
@@ -112,6 +112,12 @@ private ListenerConfigUtil() {
 
     listeners.addAll(buildListenerConfigs(brokerConf, "pinot.broker.client", 
tlsDefaults));
 
+    // support legacy behavior < 0.7.0
+    if (listeners.isEmpty()) {

Review comment:
       not sure I follow. We first attempt to create listeners from listener 
specs and an optionally set "port" variable. If neither exists, we fall back to 
a default spec.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to