jackjlli commented on a change in pull request #6361:
URL: https://github.com/apache/incubator-pinot/pull/6361#discussion_r568165047
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTestSet.java
##########
@@ -623,8 +623,10 @@ public void testReload(boolean includeOfflineTable)
JsonNode testQueryResponse = postQuery(testQuery);
// Should not throw exception during reload
assertEquals(testQueryResponse.get("exceptions").size(), 0);
- // Total docs should not change during reload
- assertEquals(testQueryResponse.get("totalDocs").asLong(),
numTotalDocs);
+ // Total docs should eventually match
+ if (testQueryResponse.get("totalDocs").asLong() != numTotalDocs) {
Review comment:
This is the unit test for testing default values. When reload request is
received, it takes time for pinot servers to update the schema.
And this `TEST_DEFAULT_COLUMNS_QUERY = "SELECT COUNT(*) FROM mytable WHERE
NewAddedIntDimension < 0"` in Line 640 queries a non-existing column in the new
schema. That's why before the new schema gets fully reloaded in pinot-server,
it'd return the totalDocs being not the same as the actual value of
numTotalDocs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
