daniellavoie commented on pull request #6440: URL: https://github.com/apache/incubator-pinot/pull/6440#issuecomment-765862374
> > > So, we are still making the assumption that the client credentials are sent via http headers. I suppose that is OK, but maybe we should also add an interface that passes the client's identity (as received via https auth) to the auth interface we have? We do have https now. > > > > > > You mean mTLS identity? Authentication should be decoupled from protocol. Fair point to not assume http headers assumption. > > Agreed about separating authentication and protocol, but you cannot do much authentication sending cleartext stuff back and forth. Anyone can impersonate easily. Even with https, if we have header based auth, it is easy to just insert some header and do what one wants to do. > > In these cases, it translates to very weak (if any) authentication. > > We used this as a first round in trusted environments. With cloud based deployments in place, I am not sure if this holds true all the time Inflight encryption and trusted identity management should not be mixed. Running "secured" authentication does requires a "secured" transport and a trusted identity provider. But I wouldn't discard the value of authentication without a secured transport since from a functional perspective, processing a request under a specific identity is valuable even though the channel is not secured (I'm thinking contextual user base request processing for dev and local use cases). The end game is you need a secured channel of course but these two aren't bound in my opinion. My takeaway is separation of concern and pluggable interfaces is paramount. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
