jihaozh commented on a change in pull request #6432:
URL: https://github.com/apache/incubator-pinot/pull/6432#discussion_r556153771
##########
File path:
thirdeye/thirdeye-dashboard/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/v2/RootCauseMetricResource.java
##########
@@ -284,11 +288,54 @@ public double getAggregate(@ApiParam(value = "metric
urn", required = true) @Que
urns = ResourceUtils.parseListParams(urns);
offsets = ResourceUtils.parseListParams(offsets);
List<MetricSlice> slices = new ArrayList<>();
+ List<String> forecastOffsets = Arrays.asList(OFFSET_FORECAST,
OFFSET_LOWER, OFFSET_UPPER);
+ Map<Pair<String, String>, Double> offsetToForecastAggregate = new
HashMap<>();
+
+ if(offsets.contains(OFFSET_FORECAST)) {
Review comment:
should this check for `OFFSET_LOWER` and `OFFSET_UPPER` as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
