Jackie-Jiang commented on a change in pull request #6409:
URL: https://github.com/apache/incubator-pinot/pull/6409#discussion_r553602502
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/datasource/BaseDataSource.java
##########
@@ -46,19 +48,29 @@ public BaseDataSource(DataSourceMetadata
dataSourceMetadata, ForwardIndexReader<
@Nullable Dictionary dictionary, @Nullable InvertedIndexReader<?>
invertedIndex,
@Nullable InvertedIndexReader<?> rangeIndex, @Nullable TextIndexReader
textIndex,
@Nullable TextIndexReader fstIndex, @Nullable JsonIndexReader jsonIndex,
@Nullable BloomFilterReader bloomFilter,
- @Nullable NullValueVectorReader nullValueVector) {
+ @Nullable NullValueVectorReader nullValueVector, @Nullable H3IndexReader
h3Index) {
Review comment:
Since all the subclasses are internal, we'd better keep them the same
order for easier maintenance in the future as we add more indexes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
