JoeFuentes-WebDev commented on a change in pull request #6421:
URL: https://github.com/apache/incubator-pinot/pull/6421#discussion_r553495609
##########
File path:
thirdeye/thirdeye-frontend/app/pods/components/composite-anomalies/entity-metrics-anomalies/template.hbs
##########
@@ -0,0 +1,24 @@
+<div class="panel-group">
+ <div class="panel panel-default">
+ <div class="panel-heading">
+ <h4 class="panel-title">
+ {{title}}
+ </h4>
+ </div>
+ {{#if tableData.length}}
+ <div class="panel-body">
+ {{models-table
+ data=tableData
+ columns=tableColumns
+ showGlobalFilter=false
+ showColumnsDropdown=false
+ customClasses=customClasses
+ }}
+ </div>
+ {{else}}
+ <p class="composite-anomalies-no-records">
+ {{noRecords}}
Review comment:
I see a few duplicate references to `{{models-table data=tableData...`
and `noRecords`.
would it make sense to extract it to a small template
{{composite-anomalies/data-table}}?
where `data-table` holds both the table itself AND the `no records` content
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
