Jackie-Jiang commented on a change in pull request #6407:
URL: https://github.com/apache/incubator-pinot/pull/6407#discussion_r552131342



##########
File path: 
pinot-tools/src/main/java/org/apache/pinot/tools/data/generator/DataGenerator.java
##########
@@ -110,7 +110,7 @@ public void generateCsv(long totalDocs, int numFiles)
       throws IOException {
     final int numPerFiles = (int) (totalDocs / numFiles);
     for (int i = 0; i < numFiles; i++) {
-      try (FileWriter writer = new FileWriter(outDir + "/output.csv")) {
+      try (FileWriter writer = new 
FileWriter(String.format("%s/output_%d.csv", outDir, i))) {

Review comment:
       Do not hard-code the file separator
   ```suggestion
         try (FileWriter writer = new FileWriter(new File(outDir, 
String.format("output_%d.csv", i)))) {
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to