yupeng9 commented on a change in pull request #6398:
URL: https://github.com/apache/incubator-pinot/pull/6398#discussion_r550848054
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/H3IndexColumn.java
##########
@@ -21,30 +21,48 @@
import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.google.common.base.Preconditions;
+import java.util.ArrayList;
import java.util.List;
+import java.util.Map;
import org.apache.commons.collections.CollectionUtils;
import org.apache.pinot.spi.config.BaseJsonConfig;
-public class H3IndexConfig extends BaseJsonConfig {
+public class H3IndexColumn extends BaseJsonConfig {
Review comment:
I feel `H3IndexColumn ` is better. In fact, I think it's possible to
make it a subclass of `FieldConfig` by adding `@Type` per
[this](https://stackoverflow.com/questions/30362446/deserialize-json-with-jackson-into-polymorphic-types-a-complete-example-is-giv).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
