kishoreg commented on a change in pull request #6397:
URL: https://github.com/apache/incubator-pinot/pull/6397#discussion_r550418324
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/geospatial/H3IndexCreator.java
##########
@@ -303,7 +339,6 @@ public static void main(String[] args)
Point point2 = GeometryUtils.GEOMETRY_FACTORY.createPoint(new
Coordinate(37.368832, -122.036346));
Review comment:
move the Main into a test case
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/datasource/BaseDataSource.java
##########
@@ -44,13 +44,10 @@
private final NullValueVectorReader _nullValueVector;
public BaseDataSource(DataSourceMetadata dataSourceMetadata,
ForwardIndexReader<?> forwardIndex,
- @Nullable Dictionary dictionary, @Nullable
InvertedIndexReader<?> invertedIndex,
- @Nullable InvertedIndexReader<?> rangeIndex,
- @Nullable H3IndexReader h3Index,
- @Nullable TextIndexReader textIndex,
- @Nullable TextIndexReader fstIndex,
- @Nullable BloomFilterReader bloomFilter,
- @Nullable NullValueVectorReader nullValueVector) {
+ @Nullable Dictionary dictionary, @Nullable InvertedIndexReader<?>
invertedIndex,
Review comment:
make sure you are using the stylesheet to format the code
##########
File path:
pinot-tools/src/main/resources/examples/batch/starbucksStores/starbucksStores_offline_table_config.json
##########
@@ -15,8 +15,11 @@
"loadMode": "MMAP",
"invertedIndexColumns": [
],
- "h3IndexColumns": [
- "location_st_point"
+ "h3IndexConfigs": [
Review comment:
I think we added a new way of adding indexing configs for each field...
can you follow the pattern used by text index? can be done in another PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
