jackjlli commented on pull request #6384: URL: https://github.com/apache/incubator-pinot/pull/6384#issuecomment-752734967
> > lgtm, not sure if v0_deprecatd is a good place to put this test, but we can always move it if needed. > > Maybe move it into `pinot-connectors/pinot-spark-connector`? Yeah I've thought about it in the first place. While pinot-spark-connector is written in scala, plus the spark version (2.12) on that isn't the same as the one in pinot-spark module (2.11), which means that there is no tests back for spark 2.11. So I'll just leave it here for now. We can always move it if necessary in the future. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
