kishoreg commented on a change in pull request #6387: URL: https://github.com/apache/incubator-pinot/pull/6387#discussion_r549013323
########## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/geospatial/H3IndexResolution.java ########## @@ -0,0 +1,53 @@ +package org.apache.pinot.core.segment.creator.impl.geospatial; + +import java.util.ArrayList; +import java.util.List; + + +/** + * Stores the resolutions for an index. There are in total of H3 resolutions https://h3geo.org/#/documentation/core-library/resolution-table + * To efficiently serialize the resolutions, we use two bytes for encoding th enabled resolutions. The resolution level + * maps to the corresponding bit. + */ +public class H3IndexResolution { + private short _resolutions; Review comment: use INT ########## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/geospatial/H3IndexCreator.java ########## @@ -172,6 +175,7 @@ public void seal() //write header file headerStream.writeInt(VERSION); headerStream.writeInt(writer.getNumUniqueIds()); + headerStream.writeShort(_resolution.size()); Review comment: why size, we should write the serialized INT right? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
