kishoreg commented on a change in pull request #6376:
URL: https://github.com/apache/incubator-pinot/pull/6376#discussion_r547705447



##########
File path: 
pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java
##########
@@ -120,6 +129,20 @@ private BaseFilterOperator 
constructPhysicalOperator(FilterContext filter,
         Predicate predicate = filter.getPredicate();
         ExpressionContext lhs = predicate.getLhs();
         if (lhs.getType() == ExpressionContext.Type.FUNCTION) {
+          FunctionContext function = lhs.getFunction();
+
+          boolean canApplyH3Index = false;
+          if 
(function.getFunctionName().equalsIgnoreCase(StDistanceFunction.FUNCTION_NAME)) 
{
+            String columnName = function.getArguments().get(0).getIdentifier();

Review comment:
       no, it means column name is the first part of the argument to 
st_distance function. I thought I handled both cases, let me check




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to