siddharthteotia commented on a change in pull request #6120:
URL: https://github.com/apache/incubator-pinot/pull/6120#discussion_r546203139
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/SegmentColumnarIndexCreator.java
##########
@@ -216,6 +225,17 @@ public void init(SegmentGeneratorConfig
segmentCreationSpec, SegmentIndexCreatio
.put(columnName, new LuceneTextIndexCreator(columnName, _indexDir,
true /* commitOnClose */));
}
+ if (_fstIndexColumns.contains(columnName)) {
+ Preconditions.checkState(fieldSpec.isSingleValueField(),
+ "FST index is currently only supported on single-value columns");
+ Preconditions.checkState(fieldSpec.getDataType() == DataType.STRING,
+ "FST index is only supported on STRING type columns");
+ Preconditions.checkState(indexCreationInfo.isCreateDictionary(),
Review comment:
isCreateDictionaryForColumn() is the correct method to be used for
checking if dictionary is to be created or not.
indexCreationInfo.isCreateDictionary() will always return true currently
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
