mcvsubbu commented on issue #6308: URL: https://github.com/apache/incubator-pinot/issues/6308#issuecomment-737607128
The key here is that there is no alert set on lack of consumption, and there is no guarantee that restarting will even fix the issue. We do have a mechanism by which servers can report problems to the controller. We use that currently for problems that happen during consumption. We may want to extend it (in case of 1 replica, maybe) to transition the segment to OFFLINE state if segment build fails (just throwing out the idea here, not sure if this is the best). In that case, the validator will come back and create a new segment. Not sure if customers are ok waiting until validator runs, or if you are looking for instant gratification. Doing something the same instant an error is reported will generally be hard if there are more the one controllers, or if validation manager starts around the same time, etc. I think we should avoid that. Validation manager can be extended to handle ERROR state in all replicas, I suppose. It needs to change the idealstate to be OFFLINE for this segment, and invoke the same logic that we have now. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
