Jackie-Jiang commented on a change in pull request #6306:
URL: https://github.com/apache/incubator-pinot/pull/6306#discussion_r534478456



##########
File path: 
pinot-core/src/main/java/org/apache/pinot/core/geospatial/transform/function/ScalarFunctions.java
##########
@@ -43,6 +44,23 @@
         .serialize(GeometryUtils.GEOMETRY_FACTORY.createPoint(new 
Coordinate(x, y)));
   }
 
+  /**
+   * Creates a point.
+   *
+   * @param x x
+   * @param y y
+   * @param isGeography if it's geography
+   * @return the created point
+   */
+  @ScalarFunction
+  public static byte[] stPoint(double x, double y, double isGeography) {

Review comment:
       The parser parses the value based on the method signature. If you change 
the third argument to `int`, it should be able to parse `1` to `int`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to