npawar commented on pull request #6296: URL: https://github.com/apache/incubator-pinot/pull/6296#issuecomment-736939120
Some more issues: 1. Can we have Delete Schema and `Edit Schema` button on the individual schema page? Otherwise there’s no way to delete/edit a schema, unless a table is also created. 2. UI side Validations for required fields on Add Schema didn’t work. I still see call being made to backend when I tried to add schema without specifying name 3. The “*” on Number of instances per replica group field spilled onto new line for my screen. We can reduce that string to Instances per replica group , or increase size of that text area. 4. When enabling Partitioning, the “segmentPrunerTypes” did not get set in the routing config. Refer to the doc for how to set. Both for REALTIME & OFFLINE 5. When Enable Partitioning, mark all mandatory fields as red *. I see it only for OFFLINE, it’s missing for REALTIME 6. In stream configs, mark these properties as mandatory - topic.name, broker.list, consumer.type, decoder.class.name 7. Seeing spinning wheel forever in this scenario - - Created a schema “foo” with 1 dimension. - Add OFFLINE table, with name “foo”. When adding table, Enable Replica Groups, and add 2 replica groups and 2 instances per replica groups (this is expected to work only with 1,1 since we have only 1 server). So, the backend returns error (expected). - But actually the table has gotten added (due to a backend bug). So if I Cancel at this stage, and refresh tables list, I see the new table (so far so good). - The problem is when I click on the new table. It spins forever. I checked the GET API and it was able to retrieve the table. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
