Jackie-Jiang commented on a change in pull request #6285:
URL: https://github.com/apache/incubator-pinot/pull/6285#discussion_r533710697
##########
File path:
pinot-core/src/test/java/org/apache/pinot/queries/DistinctQueriesTest.java
##########
@@ -170,163 +199,360 @@ private ImmutableSegment createSegment(int index,
List<GenericRow> records)
return ImmutableSegmentLoader.load(new File(INDEX_DIR, segmentName),
ReadMode.mmap);
}
+ @Test
+ public void testSingleColumnDistinctInnerSegment() {
Review comment:
Split into `testSingleColumnDistinctOnlyInnerSegment` and
`testSingleColumnDistinctOrderByInnerSegment`. I don't think we need to split
further because that is not as easy to manage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
