fx19880617 commented on a change in pull request #6299:
URL: https://github.com/apache/incubator-pinot/pull/6299#discussion_r533032361
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/metadata/SegmentMetadataImpl.java
##########
@@ -531,6 +553,12 @@ public JsonNode toJson(@Nullable Set<String> columnFilter)
{
segmentMetadata.put("creatorName", _creatorName);
segmentMetadata.put("paddingCharacter", String.valueOf(_paddingCharacter));
+ ObjectNode customConfigs = JsonUtils.newObjectNode();
+ for (String key : _customMap.keySet()) {
+ customConfigs.put(key, _customMap.get(key));
+ }
+ segmentMetadata.set("custom", customConfigs);
Review comment:
here I kind of following the convention that all the previous field
names are in strings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
