mcvsubbu commented on a change in pull request #6289:
URL: https://github.com/apache/incubator-pinot/pull/6289#discussion_r530526543
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ingestion/BatchIngestionConfig.java
##########
@@ -35,31 +35,31 @@
@JsonPropertyDescription("Configs for all the batch sources to ingest from")
private final List<Map<String, String>> _batchConfigMaps;
- @JsonPropertyDescription("Push type APPEND or REFRESH")
- private final String _segmentPushType;
+ @JsonPropertyDescription("Load type APPEND or REFRESH")
+ private final String _segmentLoadType;
- @JsonPropertyDescription("Push frequency HOURLY or DAILY")
- private final String _segmentPushFrequency;
+ @JsonPropertyDescription("Load frequency HOURLY or DAILY")
+ private final String _segmentLoadFrequency;
@JsonCreator
public BatchIngestionConfig(@JsonProperty("batchConfigMaps") @Nullable
List<Map<String, String>> batchConfigMaps,
- @JsonProperty("segmentPushType") String segmentPushType,
- @JsonProperty("segmentPushFrequency") String segmentPushFrequency) {
+ @JsonProperty("segmentLoadType") String segmentLoadType,
+ @JsonProperty("segmentLoadFrequency") String segmentLoadFrequency) {
Review comment:
Alternative suggest" `segmentIngestionFrequency` and
`segmentIngestionType`, since "load" has the connotation of a segment being
loaded in memory. Especially with the recent proposal for a segment to be in
"deep store" vs "loaded"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
