npawar commented on issue #6240: URL: https://github.com/apache/incubator-pinot/issues/6240#issuecomment-728555875
Suggested change looks good to me. I have 2 concerns 1. The dateTimeConvert udf is using this convention as well, and I believe is directly using the DateTimeFieldSpec and related classes. We might have to make changes to maintain that udf. 2. I see some usages of getColumnUnit, without checking the format first. There will be some thought needed to decide what happens to those. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
