bryantachen commented on a change in pull request #6265:
URL: https://github.com/apache/incubator-pinot/pull/6265#discussion_r524692785
##########
File path:
thirdeye/thirdeye-dashboard/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/v2/RootCauseMetricResource.java
##########
@@ -406,6 +440,30 @@ public double getAggregate(@ApiParam(value = "metric urn",
required = true) @Que
TimeGranularity granularity =
TimeGranularity.fromString(granularityString);
MetricSlice baseSlice = alignSlice(makeSlice(urn, start, end,
granularity), timezone);
+
+ if(offset.equals(OFFSET_FORECAST)) {
Review comment:
consider OFFSET_FORECAST.equals(offset) to avoid NPE
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
