fx19880617 opened a new pull request #6246:
URL: https://github.com/apache/incubator-pinot/pull/6246


   ##  Description
   Adding validation for json_extract_key and json_extract_scalar functions 
during sql compilation phase to avoid empty response
   
   If user mistakenly put double quote on a the json key argument, say 
`jsonExtractScalar(myMapStr,"$.k1", 'STRING')`, then query parser recognizes 
the second argument `$.k1` as an identifier.  Then during segment pruning 
phase, the DataSchemaSegmentPruner prunes all the segments as there is no 
column matches `$.k1`. Then user will get an empty results.
   
   Adding a function validation method during compilation time will allow us to 
find out the expression type mismatch then error out earlier and direct more 
comprehensive errors and guides to users.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to