yupeng9 commented on issue #5919: URL: https://github.com/apache/incubator-pinot/issues/5919#issuecomment-722585604
> > How do you plan to maintain this endpoint? > > Not sure if this can help with query push down as the behavior must be identical on presto side and pinot side. IMO it is safer to manually select functions to push down instead of using name matching. It can cause unexpected behavior if the behavior is not exactly the same. > > We can use reflection to auto generate this information or we can get it from TransformFunctionFactory. > I think this is useful when we have many releases of Pinot and Presto and we are keep adding new functions. > > Also cc: @yupeng9 +1 This helps a lot minimizing the efforts of syncing the functions between Pinot and Presto. Moreover, I feel there are functions from Pinot that may not be able to introduce the counterpart in Presto. For example, the IdSet function introduced by https://github.com/apache/incubator-pinot/pull/5926 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
