snleee commented on a change in pull request #6094:
URL: https://github.com/apache/incubator-pinot/pull/6094#discussion_r517861403
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java
##########
@@ -148,6 +153,23 @@ public static URI
getRetrieveAllSegmentWithTableTypeHttpUri(String host, int por
rawTableName + TYPE_DELIMITER + tableType));
}
+ public static URI getStartReplaceSegmentsURI(URI controllerURI, String
rawTableName, String tableType)
+ throws URISyntaxException {
+ return new URI(StringUtil.join("/", StringUtils
Review comment:
`getURI()` encodes `?` to `%3F`.
```
http://localhost:18998/segments/mytable/startReplaceSegments%3Ftype=OFFLINE
<- getURI(),
http://localhost:18998//segments/mytable/startReplaceSegments?type=OFFLINE
<- new URI(..)
```
When I use the request created by `getURI()`, I get 405 error.
```
org.apache.pinot.common.exception.HttpErrorStatusException: Got error status
code: 405 (Method Not Allowed) with reason: "HTTP 405 Method Not Allowed" while
sending request:
http://localhost:18998/segments/mytable/startReplaceSegments%3Ftype=OFFLINE to
controller: snlee-mn2.linkedin.biz, version: Unknown
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
