tejasajmera commented on a change in pull request #6227:
URL: https://github.com/apache/incubator-pinot/pull/6227#discussion_r516990695
##########
File path:
thirdeye/thirdeye-frontend/app/pods/components/detection-health/template.hbs
##########
@@ -1,84 +1,103 @@
-<ul class="te-horizontal-cards__single-card">
- <li class="te-horizontal-cards__card-title">
- <label for="select-dimension" class="control-label te-label--no-bottom">
- 30-day status
+<div class="te-horizontal-cards te-content-block__detection-health">
+ <h4 class="te-self-serve__block-title">
+ <label for="select-dimension" class="control-label te-label">
+ Detection health
<span>
<i class="glyphicon glyphicon-question-sign"></i>
- {{#tooltip-on-element class="te-tooltip"}}
- The overall health status of your detection configuration is based on
- the most recent 30 days.
- {{/tooltip-on-element}}
+ {{#tooltip-on-element class="te-tooltip"}}
+ See how your detection configuration is performing in detail
+ by clicking 'view details' below{{#if showRules}},
+ and select different rules above the graph
+ to see their respective regression errors{{/if}}.
+ {{/tooltip-on-element}}
</span>
</label>
- </li>
- <li class="te-horizontal-cards__card-number{{overall.label}}">
- {{overall.status}}
- </li>
- <a role="button" tabindex="0" class=".te-button--link">
- view details
- {{#bs-popover placement="bottom" title="Detection health"}}
- <p>Overall health of the metrics that monitor detection performance.</p>
+ </h4>
+ <div class="te-horizontal-cards__container">
+ <ul class="te-horizontal-cards__single-card">
+ <li class="te-horizontal-cards__card-title">
+ <label for="select-dimension" class="control-label
te-label--no-bottom">
+ 30-day status
+ <span>
+ <i class="glyphicon glyphicon-question-sign"></i>
+ {{#tooltip-on-element class="te-tooltip"}}
+ The overall health status of your detection configuration is
based on
+ the most recent 30 days.
+ {{/tooltip-on-element}}
+ </span>
+ </label>
+ </li>
+ <li class="te-horizontal-cards__card-number{{overall.label}}">
Review comment:
No, the `overall.label` points to the modifier like `--good` `--bad`
which is defined in js.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
