Jackie-Jiang commented on a change in pull request #6204:
URL: https://github.com/apache/incubator-pinot/pull/6204#discussion_r513778525
##########
File path:
pinot-core/src/test/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManagerTest.java
##########
@@ -800,7 +800,8 @@ public
FakeLLRealtimeSegmentDataManager(RealtimeSegmentZKMetadata segmentZKMetad
throws Exception {
super(segmentZKMetadata, tableConfig, realtimeTableDataManager,
resourceDataDir,
new IndexLoadingConfig(makeInstanceDataManagerConfig(),
tableConfig), schema, llcSegmentName,
- semaphoreMap.get(llcSegmentName.getPartitionId()), serverMetrics,
new PartitionUpsertMetadataManager());
+ semaphoreMap.get(llcSegmentName.getPartitionId()), serverMetrics,
+ new PartitionUpsertMetadataManager("testTable", 0, serverMetrics));
Review comment:
```suggestion
new PartitionUpsertMetadataManager("testTable_REALTIME", 0,
serverMetrics));
```
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/upsert/PartitionUpsertMetadataManager.java
##########
@@ -85,7 +97,6 @@ public ThreadSafeMutableRoaringBitmap addSegment(String
segmentName, Iterator<Re
// committing a consuming segment, or reloading a completed
segment.
// Update the record location when the new timestamp is greater
than or equal to the current timestamp.
- // Update the record location when there is a tie because the
record locations should point to the new
Review comment:
Revert this removal
##########
File path:
pinot-core/src/test/java/org/apache/pinot/core/plan/maker/MetadataAndDictionaryAggregationPlanMakerTest.java
##########
@@ -119,9 +121,11 @@ public void buildSegment()
public void loadSegment()
throws Exception {
_indexSegment = ImmutableSegmentLoader.load(new File(INDEX_DIR,
SEGMENT_NAME), ReadMode.heap);
+ ServerMetrics serverMetrics = Mockito.mock(ServerMetrics.class);
_upsertIndexSegment = ImmutableSegmentLoader.load(new File(INDEX_DIR,
SEGMENT_NAME), ReadMode.heap);
((ImmutableSegmentImpl) _upsertIndexSegment)
- .enableUpsert(new PartitionUpsertMetadataManager(), new
ThreadSafeMutableRoaringBitmap());
+ .enableUpsert(new PartitionUpsertMetadataManager("testTable", 0,
serverMetrics),
Review comment:
```suggestion
.enableUpsert(new
PartitionUpsertMetadataManager("testTable_REALTIME", 0, serverMetrics),
```
##########
File path:
pinot-core/src/test/java/org/apache/pinot/core/upsert/PartitionUpsertMetadataManagerTest.java
##########
@@ -34,10 +36,12 @@
public class PartitionUpsertMetadataManagerTest {
private static final String SEGMENT_PREFIX = "testSegment";
+ private static final String TEST_TABLE = "testTable";
Review comment:
```suggestion
private static final String REALTIME_TABLE_NAME = "testTable_REALTIME";
```
##########
File path:
pinot-core/src/test/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImplUpsertTest.java
##########
@@ -58,7 +60,8 @@ public void setup()
.setUpsertConfig(new UpsertConfig(UpsertConfig.Mode.FULL)).build();
_recordTransformer =
CompositeTransformer.getDefaultTransformer(_tableConfig, _schema);
File jsonFile = new File(dataResourceUrl.getFile());
- _partitionUpsertMetadataManager = new
TableUpsertMetadataManager().getOrCreatePartitionManager(0);
+ _partitionUpsertMetadataManager =
+ new TableUpsertMetadataManager("testTable",
Mockito.mock(ServerMetrics.class)).getOrCreatePartitionManager(0);
Review comment:
```suggestion
new TableUpsertMetadataManager("testTable_REALTINE",
Mockito.mock(ServerMetrics.class)).getOrCreatePartitionManager(0);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
