This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch test-branch
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/test-branch by this push:
new 7eacab6 Hotfix LuceneDocIdCollector
7eacab6 is described below
commit 7eacab677e040e5c9a37bb86448d35c13dc29158
Author: Jack Li(Analytics Engineering) <j...@jlli-mn1.linkedin.biz>
AuthorDate: Wed Oct 28 11:55:17 2020 -0700
Hotfix LuceneDocIdCollector
---
.../pinot/core/segment/index/readers/text/LuceneDocIdCollector.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
a/pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/text/LuceneDocIdCollector.java
b/pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/text/LuceneDocIdCollector.java
index 9d9fd35..723dd00 100644
---
a/pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/text/LuceneDocIdCollector.java
+++
b/pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/text/LuceneDocIdCollector.java
@@ -67,7 +67,9 @@ public class LuceneDocIdCollector implements Collector {
@Override
public void collect(int doc) throws IOException {
- // Compute the absolute lucene docID across
+ // even though we merge lucene sub-indexes, there could still be cases
+ // that can lead to multiple sub-indexes. For search on multiple
+ // sub-indexes, we need to use compute the absolute lucene docID across
// sub-indexes because that's how the lookup table in docIdTranslator
is built
_docIds.add(_docIdTranslator.getPinotDocId(context.docBase + doc));
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
