siddharthteotia commented on pull request #6192: URL: https://github.com/apache/incubator-pinot/pull/6192#issuecomment-716887472
> > Can we make the sql queries one-to-one mapping with the pql queries? > > It's a good idea but the thing is that there are some restrictions in SQL comparisons, e.g. in SQL we skip the comparison of MV columns. So if we make it one to one mapping, the number of queries will be reduced. > Plus, SQL requires the order by column to be appeared in the selection clause, which requires us to modify the original queries. And the selection queries without order by are missing in the original query files as well, as the logic of comparing selection w/o order by is missing in the code. @jackjlli , SQL doesn't require the order by column to be present in the selection clause. May be you meant GROUP BY since that requires the query change. Also, I don't think we should skip comparing MV columns for SQL. Why can't we leverage the same comparator (that works for PQL) for SQL queries as well? Doing 1-1 test between PQL and SQL would be perfect apples to apples comparison ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
