jtao15 commented on a change in pull request #6184:
URL: https://github.com/apache/incubator-pinot/pull/6184#discussion_r511234621
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/ClusterTest.java
##########
@@ -184,7 +184,7 @@ protected void startMinion(@Nullable Map<String,
PinotTaskExecutorFactory> taskE
FileUtils.deleteQuietly(new File(Minion.DEFAULT_INSTANCE_BASE_DIR));
try {
_minionStarter =
- new MinionStarter(ZkStarter.DEFAULT_ZK_STR, getHelixClusterName(),
new PinotConfiguration());
+ new MinionStarter(getHelixClusterName(), ZkStarter.DEFAULT_ZK_STR,
new PinotConfiguration());
Review comment:
I switched the order of the first 2 parameters for `MinionStarter` to be
consistent with other starters constructors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
