sajjad-moradi commented on a change in pull request #6181:
URL: https://github.com/apache/incubator-pinot/pull/6181#discussion_r510979784
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTestSet.java
##########
@@ -320,19 +320,17 @@ public void testQueriesFromQueryFile()
assertNotNull(resourceUrl);
File queryFile = new File(resourceUrl.getFile());
- int maxNumQueriesToSkipInQueryFile = getMaxNumQueriesToSkipInQueryFile();
try (BufferedReader reader = new BufferedReader(new
FileReader(queryFile))) {
while (true) {
- int numQueriesSkipped = RANDOM.nextInt(maxNumQueriesToSkipInQueryFile);
- for (int i = 0; i < numQueriesSkipped; i++) {
- reader.readLine();
- }
-
String queryString = reader.readLine();
// Reach end of file.
if (queryString == null) {
return;
}
+ // Skip commented line and empty line.
+ if (queryString.startsWith("#") || queryString.isEmpty()) {
Review comment:
Use `queryString.trim()` to include leading whitespaces before # or
empty lines with only whitespaces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
