Jackie-Jiang commented on a change in pull request #6176:
URL: https://github.com/apache/incubator-pinot/pull/6176#discussion_r510448133
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/RangeIndexBasedFilterOperator.java
##########
@@ -56,12 +56,12 @@ protected FilterBlock getNextBlock() {
int firstRangeId;
int lastRangeId;
- if (_rangePredicateEvaluator instanceof
OfflineDictionaryBasedRangePredicateEvaluator) {
+ if (_rangePredicateEvaluator instanceof
SortedDictionaryBasedRangePredicateEvaluator) {
Review comment:
Yes. We should determine the evaluator by whether the dictionary is
sorted, instead of the instance of the dictionary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
