Jackie-Jiang opened a new pull request #6176: URL: https://github.com/apache/incubator-pinot/pull/6176
## Description Motivation: Currently the APIs for Dictionary is split in 3 places: `Dictionary`, `BaseImmutableDictionary`, `BaseMutableDictionary`. In order to use them, we need to cast the dictionary first, which is hard to manage and can potentially cause casting error. E.g. #6174 is caused by casting an immutable dictionary to `BaseMutableDictionary`. We should move the common read APIs to the root `Dictionary` interface to avoid the casting, and let all types of dictionary support these APIs. Merge the following common APIs from `BaseImmutableDictionary` and `BaseMutableDictionary` to `Dictionary`: - `insertionIndexOf` - `getDictIdsInRange` - `compare` - `getMinVal` - `getMaxVal` - `getSortedValues` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
