Jackie-Jiang commented on a change in pull request #6153:
URL: https://github.com/apache/incubator-pinot/pull/6153#discussion_r508712115
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java
##########
@@ -265,6 +265,12 @@ protected static void validateUpsertConfig(TableConfig
tableConfig, Schema schem
tableConfig.getRoutingConfig() != null &&
RoutingConfig.REPLICA_GROUP_INSTANCE_SELECTOR_TYPE
.equalsIgnoreCase(tableConfig.getRoutingConfig().getInstanceSelectorType()),
"Upsert table must use replica-group (i.e. replicaGroup) based
routing");
+ // no startree index
+ if (tableConfig.getIndexingConfig() != null &&
tableConfig.getIndexingConfig().getStarTreeIndexConfigs() != null) {
+ Preconditions.checkState(
+ tableConfig.getIndexingConfig().getStarTreeIndexConfigs().isEmpty()
&& !tableConfig.getIndexingConfig()
+ .isEnableDefaultStarTree(), "The upsert table cannot have
star-tree index.");
+ }
Review comment:
```suggestion
Preconditions.checkState(
CollectionUtils.isEmpty(tableConfig.getIndexingConfig().getStarTreeIndexConfigs())
&& !tableConfig
.getIndexingConfig().isEnableDefaultStarTree(), "The upsert
table cannot have star-tree index.");
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
