mayankshriv commented on pull request #6139: URL: https://github.com/apache/incubator-pinot/pull/6139#issuecomment-710176443
> I'm against changing the data to a static file. The purpose of the quick start is letting the user play with Pinot and they should be able to see the latest events from a real stream instead of the unchanged records. Is there a way to solve this issue without hardcode the data file? > Also, I'm not able to reproduce this issue locally. Did I miss something? @Jackie-Jiang The tyrus dependency causes a lot of issues for me as well, e.g. when running perfBenchmarkRunner locally. I agree we should have recipe/setup/demo using live stream. However, note that quickStart is also being used as a test, which makes it brittle if upstream has an issue (we had this recently). My recommendation is to have the test part of quick-start read data from a deterministic source (e.g. local stream or static file). However, in this case, quick-start (as a user demo tool) remains untested. For this, we could have a quick-start test based on real stream only when cutting the release (instead of all commits). What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
