Jackie-Jiang commented on a change in pull request #6149:
URL: https://github.com/apache/incubator-pinot/pull/6149#discussion_r505924807
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java
##########
@@ -230,6 +235,39 @@ private static void validateIngestionConfig(@Nullable
IngestionConfig ingestionC
}
}
+ /**
+ * Validates the upsert-related configurations
+ * - check table type is realtime
+ * - the primary key exists on the schema
+ * - replica group is configured for routing type
+ * - consumer type must be low-level
+ */
+ protected static void validateUpsertConfig(TableConfig tableConfig, Schema
schema) {
+ if (tableConfig.getUpsertMode() == UpsertConfig.Mode.NONE) {
+ return;
+ }
+ // check table type is realtime
+ if (tableConfig.getTableType() != TableType.REALTIME) {
Review comment:
(nit) Use precondition for this as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
