mcvsubbu commented on a change in pull request #6113:
URL: https://github.com/apache/incubator-pinot/pull/6113#discussion_r504839631
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
##########
@@ -378,7 +463,12 @@ public void replaceLLSegment(String segmentName,
IndexLoadingConfig indexLoading
try {
File indexDir = new File(_indexDir, segmentName);
Schema schema = ZKMetadataProvider.getTableSchema(_propertyStore,
_tableNameWithType);
- addSegment(ImmutableSegmentLoader.load(indexDir, indexLoadingConfig,
schema));
+ PartitionUpsertMetadataManager partitionUpsertMetadataManager = null;
+ if (_tableUpsertMetadataManager != null) {
+ int partitionId = new LLCSegmentName(segmentName).getPartitionId();
Review comment:
We should find a better way of getting `partitionId` than from the
segment name. We are looking to integrate with other streams where partition ID
is not an integer (e.g. kinesis). In that case, this will not work.
@npawar may also want to comment on this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
