yupeng9 commented on pull request #6141: URL: https://github.com/apache/incubator-pinot/pull/6141#issuecomment-708525828
> `disableUpsert` is a bit confusing. Initially it led me to believe that it is actually going to disable upsert operation, which led me to question why the read path should have the option to disable upsert in the write path. > > Upon reading the changes, I feel a better name might be something along the lines of `skipUpsert`, `ignoreUpsert` or `skipUpsertedDocIds`, for better readability. Makes sense. I prefer `skipUpsert`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
