jamesyfshao commented on a change in pull request #6113: URL: https://github.com/apache/incubator-pinot/pull/6113#discussion_r503701683
########## File path: pinot-core/src/main/java/org/apache/pinot/core/upsert/PartitionUpsertMetadataManager.java ########## @@ -0,0 +1,103 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.upsert; + +import java.util.HashSet; +import java.util.Map; +import java.util.concurrent.ConcurrentHashMap; +import javax.annotation.concurrent.ThreadSafe; +import org.apache.pinot.core.realtime.impl.ThreadSafeMutableRoaringBitmap; +import org.apache.pinot.spi.data.readers.PrimaryKey; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * Manages the upsert metadata per partition. + */ +@ThreadSafe +public class PartitionUpsertMetadataManager { Review comment: I mean for a new component like this it will be great if they are implemented as interface -> concrete class. This provides multiple benefits: 1. it allows people to use different implementations of the same upsert logics. Think of someone who wants to use a key/value mapping backed by rocksdb, it will be much easier to swap this part out if it is backed by an interface. 2. it allows us to provide a dummy implementation of MetadataManager for append-only segmentImpl. For example, this could be one `PartitionUpsertMetadataManager` and `PartitionAppendMetadataManager` both extends `PartitionMetadataManager` interface. This way it would allow us to create a concrete class based on whether we are dealing with upsert/append table and avoid the branching conditions for append/upsert logics ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
