[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6105: scalar functions for array

[GitBox]

Jackie-Jiang commented on a change in pull request #6105:
URL: https://github.com/apache/incubator-pinot/pull/6105#discussion_r502733858



##########
File path: 
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionUtils.java
##########
@@ -50,12 +59,22 @@ private FunctionUtils() {
     put(Boolean.class, PinotDataType.BOOLEAN);
     put(Character.class, PinotDataType.CHARACTER);
     put(Short.class, PinotDataType.SHORT);
+    put(int.class, PinotDataType.INTEGER);
     put(Integer.class, PinotDataType.INTEGER);
     put(Long.class, PinotDataType.LONG);
     put(Float.class, PinotDataType.FLOAT);
     put(Double.class, PinotDataType.DOUBLE);
     put(String.class, PinotDataType.STRING);
     put(byte[].class, PinotDataType.BYTES);
+    put(int[].class, PinotDataType.INTEGER_ARRAY);
+    put(Integer[].class, PinotDataType.INTEGER_ARRAY);
+    put(long[].class, PinotDataType.LONG_ARRAY);
+    put(Long[].class, PinotDataType.INTEGER_ARRAY);

Review comment:
       ```suggestion
       put(Long[].class, PinotDataType. LONG_ARRAY);
   ```

##########
File path: 
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionUtils.java
##########
@@ -82,6 +110,15 @@ private FunctionUtils() {
     put(Double.class, ColumnDataType.DOUBLE);
     put(String.class, ColumnDataType.STRING);
     put(byte[].class, ColumnDataType.BYTES);
+    put(int[].class, ColumnDataType.INT);
+    put(Integer[].class, ColumnDataType.INT);
+    put(long[].class, ColumnDataType.FLOAT);
+    put(Long[].class, ColumnDataType.FLOAT);

Review comment:
       ```suggestion
       put(long[].class, ColumnDataType.LONG);
       put(Long[].class, ColumnDataType.LONG);
   ```

##########
File path: 
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionUtils.java
##########
@@ -50,12 +59,22 @@ private FunctionUtils() {
     put(Boolean.class, PinotDataType.BOOLEAN);
     put(Character.class, PinotDataType.CHARACTER);
     put(Short.class, PinotDataType.SHORT);
+    put(int.class, PinotDataType.INTEGER);

Review comment:
       Remove this one as argument is always an `Object`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org