npawar commented on a change in pull request #6046:
URL: https://github.com/apache/incubator-pinot/pull/6046#discussion_r502591789



##########
File path: 
pinot-plugins/pinot-input-format/pinot-csv/src/main/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordExtractor.java
##########
@@ -69,4 +70,32 @@ public GenericRow extract(CSVRecord from, GenericRow to) {
     }
     return to;
   }
+
+  @Override
+  @Nullable
+  public Object convert(@Nullable Object value) {

Review comment:
       I think you missed removing this code from `extract` and also calling 
`convert`  above in the `extract`. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to