KKcorps commented on a change in pull request #6119:
URL: https://github.com/apache/incubator-pinot/pull/6119#discussion_r502299769
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/Constants.java
##########
@@ -36,6 +36,7 @@
public static final String SCHEMA_TAG = "Schema";
public static final String TENANT_TAG = "Tenant";
public static final String BROKER_TAG = "Broker";
+ public static final String BROKER_V2_TAG = "BrokerV2";
Review comment:
removed
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/helix/HelixHelper.java
##########
@@ -474,6 +480,12 @@ public IdealState apply(@Nullable IdealState idealState) {
* TODO: refactor code to use this method if applicable to reuse instance
configs in order to reduce ZK accesses
*/
public static Set<String> getBrokerInstancesForTenant(List<InstanceConfig>
instanceConfigs, String tenant) {
- return new HashSet<>(HelixHelper.getInstancesWithTag(instanceConfigs,
TagNameUtils.getBrokerTagForTenant(tenant)));
+ return getBrokerInstanceConfigsForTenant(instanceConfigs,
tenant).stream().map(InstanceConfig::getInstanceName).collect(
+ Collectors.toSet());
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
