snleee commented on a change in pull request #6094:
URL: https://github.com/apache/incubator-pinot/pull/6094#discussion_r501908515



##########
File path: 
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java
##########
@@ -148,6 +153,23 @@ public static URI 
getRetrieveAllSegmentWithTableTypeHttpUri(String host, int por
         rawTableName + TYPE_DELIMITER + tableType));
   }
 
+  public static URI getStartReplaceSegmentsHttpURI(URI controllerURI, String 
rawTableName, String tableType)

Review comment:
       Added java docs. Also, this supports both http/https because we reuse 
http/https provided from `controllerURI`. I changed the function name to 
`getStartReplaceSegmentsURI` to avoid the confusion.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to